Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove config of temporary_superset_ui #18708

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Feb 14, 2022

SUMMARY

follow PR, then remove unused config of temporary_superset_ui

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI passes

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #18708 (32721aa) into master (324a15d) will not change coverage.
The diff coverage is n/a.

❗ Current head 32721aa differs from pull request most recent head 9f8def1. Consider uploading reports for the commit 9f8def1 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18708   +/-   ##
=======================================
  Coverage   66.28%   66.28%           
=======================================
  Files        1605     1605           
  Lines       62863    62863           
  Branches     6341     6341           
=======================================
  Hits        41666    41666           
  Misses      19545    19545           
  Partials     1652     1652           
Flag Coverage Δ
javascript 51.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324a15d...9f8def1. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit ea12024 into apache:master Feb 14, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants