Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mssql): support top syntax for limiting queries #18746

Merged
merged 16 commits into from
Feb 21, 2022
Merged

fix(mssql): support top syntax for limiting queries #18746

merged 16 commits into from
Feb 21, 2022

Commits on Feb 15, 2022

  1. SQL-TOP Fix For Database Engines 

    MSSQL is not supporting LIMIT syntax in SQLs. For limiting the rows, MSSQL having a different keyword TOP. Added fixes for handling the TOP and LIMIT clauses based on the database engines.
    @sujiplr
    sujiplr committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    55c71a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Teradata code for top clause handling removed from teradata.py 

    Teradata code for top clause handling removed from teradata.py file, since we added generic section in base engine for the same.
    @sujiplr
    sujiplr committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    6913d73 View commit details
    Browse the repository at this point in the history

  2. Changes to handle CTE along with TOP in complex SQLs 

    Added changes to handle TOP command in CTEs, for DB Engines which are not supporting inline CTEs.
    @sujiplr
    sujiplr committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    e4f98a6 View commit details
    Browse the repository at this point in the history

  3. Test cases for TOP unit testing in MSSQL 

    Added multiple unit test cases for MSSQL top command handling and also along with CTEs
    @sujiplr
    sujiplr committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    7712f73 View commit details
    Browse the repository at this point in the history

  4. Corrected the select_keywords name key in basengine 

    Corrected the select_keywords name key in basengine
    @sujiplr
    sujiplr committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    de0cd2a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. Changes based on as per review. 

    made the required corrections based on code review to keep good code readability and code cleanliness.
    @sujiplr
    sujiplr committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    28d3e70 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Review changes to correct lint and typo issues 

    Made the changes according to the review comments.
    @sujiplr
    sujiplr committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    e9b51a6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into SQL-TOP-FIX

    @villebro
    villebro committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    cdc3ea4 View commit details
    Browse the repository at this point in the history

  3. fix linting errors

    @villebro
    villebro committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    5d1ffda View commit details
    Browse the repository at this point in the history

  4. fix teradata tests

    @villebro
    villebro committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    bee00c0 View commit details
    Browse the repository at this point in the history

  5. add coverage

    @villebro
    villebro committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    17738f3 View commit details
    Browse the repository at this point in the history

  6. lint

    @villebro
    villebro committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    d5f45bb View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2022

  1. Code cleanliness 

    Moved the top/limit flag check from sql_lab to core.
    @sujiplr
    sujiplr committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    7c80cea View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Changed for code cleanliness 

    Changes for keeping code cleanliness
    @sujiplr
    sujiplr committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    37ba4b5 View commit details
    Browse the repository at this point in the history

  2. Corrected lint issue 

    Corrected lint issue.
    @sujiplr
    sujiplr committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    4c7ec51 View commit details
    Browse the repository at this point in the history

  3. Code cleanliness 

    Code cleanliness
    @sujiplr
    sujiplr committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    ee37d94 View commit details
    Browse the repository at this point in the history