fix(sqllab): Removed the tooltip from CopyToClipboard button in sqllab

[prosdev0107]

SUMMARY

Removed the tooltip from CopyToClipboard button in sqllab

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[zhaoyongjie]

It was a generic component and it was used in other components. You shouldn't remove the tooltip.

[rusackas]

Agreed, the solution should be prop-based. Either

• render the tooltip conditionally (if it was passed a meaningful title)
• provide a prop or other means (e.g. title={false}) to intentionally hide the tooltip

[rusackas]

I think this solves the issue in a much more simple/estensible way.

Two non-blocking things worth consideration:

• Minor, but: since the norm is that the tooltip is visible, should the (optional) prop be hideTooltip with a default of false? Just a philosophy question, it works either way.
• The two blocks of JSX in renderNotWrapped and renderLink are nearly identical. Should we DRY that up while we're at it here?

[rusackas]

Oh, it would also be nice if the new prop is reflected/togglable in the Storybook entry.

[rusackas]

Sorry to keep asking for things, but... can we add an RTL (React Testing Library) test here to make sure it stays working with and without the prop?

[codecov]

Codecov Report

Merging #18749 (babd0e1) into master (5bb406b) will decrease coverage by 0.00%.
The diff coverage is 87.93%.

❗ Current head babd0e1 differs from pull request most recent head 04c1c35. Consider uploading reports for the commit 04c1c35 to get more accurate results

@@            Coverage Diff             @@
##           master   #18749      +/-   ##
==========================================
- Coverage   66.32%   66.32%   -0.01%     
==========================================
  Files        1620     1620              
  Lines       63060    63089      +29     
  Branches     6368     6373       +5     
==========================================
+ Hits        41823    41842      +19     
- Misses      19579    19590      +11     
+ Partials     1658     1657       -1     

Flag	Coverage Δ
javascript	51.26% <84.09%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts	100.00% <ø> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx	50.73% <ø> (ø)
superset-frontend/src/components/Button/index.tsx	100.00% <ø> (ø)
...board/components/nativeFilters/FilterBar/index.tsx	69.82% <ø> (ø)
...d/src/explore/components/PropertiesModal/index.tsx	70.00% <ø> (+1.66%)	⬆️
superset-frontend/src/views/App.tsx	0.00% <0.00%> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx	52.23% <0.00%> (ø)
superset/initialization/__init__.py	90.65% <ø> (+0.45%)	⬆️
superset/reports/api.py	89.84% <ø> (ø)
...ontend/src/explore/components/QueryAndSaveBtns.tsx	50.00% <80.00%> (ø)
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb406b...04c1c35. Read the comment docs.

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://52.24.232.107:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.