fix(key-value): lost url_params after long-url feature #18846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
commented
Feb 22, 2022
| if value: | ||
| initial_form_data = json.loads(value) | ||
| initial_form_data = json.loads(value) if value else {} |
zhaoyongjie
changed the title
| @@ -175,6 +175,19 @@ const updateHistory = debounce( | |||
| additionalParam[URL_PARAMS.datasetId.name] = datasetId; | |||
| } | |||
|
|
|||
| const urlParams = payload?.url_params || {}; | |||
There was a problem hiding this comment.
Wouldn't be cleaner to just initialize additionalParam with payload?.url_params? If some of the parameters are already in the URL they will be overridden anyway. This way you don't need the forEach and the if check.
There was a problem hiding this comment.
Wouldn't be cleaner to just initialize additionalParam with payload?.url_params?
formDataKeyin urlParams- it isn't known which url_params don't need to be put into
additionalParamsin the future.
If some of the parameters are already in the URL they will be overridden anyway. This way you don't need the forEach and the if check.
There needs to be a pattern that controls which params can be put in, and which do not.
BTW, chartId and datasetId come from elsewhere even though they are the same as urlParams. (link)
villebro
approved these changes
Feb 22, 2022
rosemarie-chiu
pushed a commit
to preset-io/superset
that referenced
this pull request
Feb 22, 2022
(cherry picked from commit 4c16586)
|
🏷 preset:2022.7 |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, the parameters in the browser can't show in URL. This PR resolved it.
partial fix #16650
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION