Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-filters): Don't scroll main window when scrolling filter bar #18876

Merged
merged 1 commit into from Feb 23, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

When user scrolls to the bottom of filter bar and keeps scrolling, the whole dashboard starts scrolling. Filter bar should be independent from dashboard, so this PR detaches filter bar scroll from main window scroll.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-02-23.at.14.00.40.mov

After:

Screen.Recording.2022-02-23.at.13.58.57.mov

TESTING INSTRUCTIONS

  1. Open a dashboard with native filters
  2. Add multiple native filters and multiple charts, so that filters bar and dashboard are both scrollable
  3. Verify that scrolling while hovering over filters bar doesn't trigger scrolling of main window

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @rusackas @kasiazjc

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #18876 (d1da0c4) into master (700829b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18876   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files        1621     1621           
  Lines       63057    63058    +1     
  Branches     6382     6382           
=======================================
+ Hits        41850    41851    +1     
  Misses      19547    19547           
  Partials     1660     1660           
Flag Coverage Δ
javascript 51.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...board/components/nativeFilters/FilterBar/index.tsx 67.22% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700829b...d1da0c4. Read the comment docs.

@kgabryje kgabryje merged commit e5c7478 into apache:master Feb 23, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants