fix: remove unneeded complexity in migration #19022
Merged
+7
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The migration from SIP-68 was calling
create_engine
just to get the dialect associated with a given database. This required reimplementing many methods in the customDatabase
class defined in the migration, since it requires doing user impersonation, mutating the connection string, and much more. This was failing for BigQuery because it was not finding the credentials:Turns out there's a simpler way of getting the dialect associated with a database that doesn't require
create_engine
. I implemented it in this PR.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Migration should run fine. I ran a downgrade and upgrade and it works fine, but I only testes with Postgres.
ADDITIONAL INFORMATION