Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix deprecated unittest aliases. #19042

Merged
merged 1 commit into from Mar 7, 2022

Conversation

tirkarthi
Copy link
Contributor

SUMMARY

Fix deprecated unittest aliases. The deprecated aliases were removed in Python 3.11 and the change was reverted later to keep warnings only. Similar to #17562

Command to check for deprecated aliases

rg -t py 'assertEquals|assertNotEquals|assertAlmostEquals|assertNotAlmostEquals|assertRegexpMatches|assertNotRegexpMatches|assertRaisesRegexp|failUnlessEqual|failIfEqual|failUnlessAlmostEqual|failUnless|failUnlessRaises|failIf|assertDictContainsSubset|_TextTestResult'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #19042 (21b8cef) into master (8c52fe3) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 21b8cef differs from pull request most recent head 4c9cf36. Consider uploading reports for the commit 4c9cf36 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19042      +/-   ##
==========================================
- Coverage   66.52%   66.33%   -0.20%     
==========================================
  Files        1641     1641              
  Lines       63476    63476              
  Branches     6444     6444              
==========================================
- Hits        42227    42106     -121     
- Misses      19585    19706     +121     
  Partials     1664     1664              
Flag Coverage Δ
hive ?
mysql 81.81% <ø> (ø)
postgres 81.86% <ø> (ø)
presto ?
python 81.90% <ø> (-0.39%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.00% <0.00%> (-15.77%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-5.65%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/connectors/sqla/utils.py 88.23% <0.00%> (-3.93%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/result_set.py 96.77% <0.00%> (-1.62%) ⬇️
superset/databases/commands/test_connection.py 98.57% <0.00%> (-1.43%) ⬇️
superset/connectors/sqla/models.py 88.87% <0.00%> (-1.24%) ⬇️
superset/utils/cache.py 73.58% <0.00%> (-0.95%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c52fe3...4c9cf36. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @tirkarthi !

@villebro villebro merged commit 864bafc into apache:master Mar 7, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants