Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scroll to bottom when adding a new native filter and the page is filled #19053

Merged
merged 3 commits into from Mar 17, 2022
Merged

feat: scroll to bottom when adding a new native filter and the page is filled #19053

merged 3 commits into from Mar 17, 2022

Conversation

diegomedina248
Copy link
Contributor

@diegomedina248 diegomedina248 commented Mar 8, 2022 •
edited by michael-s-molina

SUMMARY

When adding a native filter, and the page is already filled (with other filters), auto-scroll to the bottom so that the newly added filter is visible on the left panel.

Also, fixes a typo in the onRearrange function.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-03-07.at.21.56.31.mov

After:

Screen.Recording.2022-03-07.at.21.50.20.mov

TESTING INSTRUCTIONS

  1. Go to any dashboard
  2. Hit the Add/Edit filters button on the left panel
  3. Start adding filters & dividers
  4. Ensure that, when the filter container fills the screen, adding new filters scrolls the container to the bottom

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@yousoph
Copy link
Member

yousoph commented Mar 8, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

@yousoph Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

@yousoph Ephemeral environment creation failed. Please check the Actions logs for details.

@rusackas
Copy link
Member

rusackas commented Mar 9, 2022

Unit tests have failed on this one a couple times despite re-running CI... could you check to see if they're passing locally?

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #19053 (2b1922a) into master (f9c7405) will increase coverage by 0.00%.
The diff coverage is 55.31%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19053   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files        1642     1643    +1     
  Lines       63442    63460   +18     
  Branches     6439     6449   +10     
=======================================
+ Hits        42191    42205   +14     
- Misses      19582    19585    +3     
- Partials     1669     1670    +1
Flag Coverage Δ
javascript 51.24% <55.31%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ilters/FiltersConfigModal/FilterTitleContainer.tsx 57.14% <48.78%> (ø)
...tiveFilters/FiltersConfigModal/DraggableFilter.tsx 71.87% <100.00%> (ø)
...Filters/FiltersConfigModal/FilterConfigurePane.tsx 100.00% <100.00%> (ø)
...tiveFilters/FiltersConfigModal/FilterTitlePane.tsx 83.33% <100.00%> (+2.08%) ⬆️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 64.67% <100.00%> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 50.84% <0.00%> (-0.60%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 47.15% <0.00%> (ø)
...perset-frontend/src/addSlice/AddSliceContainer.tsx 61.76% <0.00%> (ø)
...rontend/src/visualizations/TimeTable/TimeTable.jsx 0.00% <0.00%> (ø)
superset-frontend/src/utils/sortNumericValues.ts 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c7405...2b1922a. Read the comment docs.

rusackas
rusackas reviewed Mar 9, 2022
View reviewed changes
...frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx
@@ -65,7 +72,7 @@ test('renders form', async () => {

test('drag and drop', async () => {
defaultRender();
// Drag the state and contry filter above the product filter
// Drag the state and country filter above the product filter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up all the typos and things along the way. You're making the world a better place! 🧹 ✨

@rusackas
Copy link
Member

rusackas commented Mar 9, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

@rusackas Ephemeral environment spinning up at http://34.220.228.251:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas
rusackas approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and works well in testing. Just re-triggered E2E tests 🤞 . CC @kgabryje and @michael-s-molina in case you spot any risks I didn't.

kgabryje
kgabryje approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit cfb967f into apache:master Mar 17, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.11

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 18, 2022
@diegomedina248 @sadpandajoe
feat: scroll to bottom when adding a new native filter and the page i…
2597ed3 
…s filled (apache#19053)

* feat: Scroll to bottom when adding a new native filter and the page is filled

* Add test

(cherry picked from commit cfb967f)
villebro pushed a commit that referenced this pull request Apr 3, 2022
@diegomedina248 @villebro
feat: scroll to bottom when adding a new native filter and the page i…
71338ca 
…s filled (#19053)

* feat: Scroll to bottom when adding a new native filter and the page is filled

* Add test

(cherry picked from commit cfb967f)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@kgabryje kgabryje kgabryje approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.11 size/L 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@diegomedina248 @yousoph @rusackas @sadpandajoe @kgabryje @michael-s-molina @mistercrunch @villebro