fix: clean up chart metadata config

[suddjian]

SUMMARY

Removing the deprecated field turns out to have been a bit much. Separately, flattening the label object into two separate fields allows us to better specify defaults and overrides for things.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

tested both deprecation and labels, and they still work as before.

TESTING INSTRUCTIONS

Set a plugin's metadata to have deprecated: true or label: ChartLabel.FEATURED and find it (or don't, if it's deprecated) in the viz picker.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[rusackas]

Thank you for the fixes here!

[codecov]

Codecov Report

Merging #19143 (417cd0c) into master (981f09b) will decrease coverage by 0.00%.
The diff coverage is 57.14%.

❗ Current head 417cd0c differs from pull request most recent head 0de8cab. Consider uploading reports for the commit 0de8cab to get more accurate results

@@            Coverage Diff             @@
##           master   #19143      +/-   ##
==========================================
- Coverage   66.55%   66.55%   -0.01%     
==========================================
  Files        1646     1646              
  Lines       63617    63625       +8     
  Branches     6471     6475       +4     
==========================================
+ Hits        42340    42344       +4     
- Misses      19599    19602       +3     
- Partials     1678     1679       +1     

Flag	Coverage Δ
javascript	51.26% <57.14%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ponents/controls/VizTypeControl/VizTypeGallery.tsx	87.09% <25.00%> (-0.48%)	⬇️
...superset-ui-core/src/chart/models/ChartMetadata.ts	100.00% <100.00%> (ø)
.../packages/superset-ui-core/src/chart/types/Base.ts	100.00% <100.00%> (ø)
...frontend/src/components/TimezoneSelector/index.tsx	93.93% <0.00%> (-3.04%)	⬇️
superset-frontend/src/embedded/index.tsx	0.00% <0.00%> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts	100.00% <0.00%> (ø)
...reset-chart-deckgl/src/utilities/Shared_DeckGL.jsx	86.48% <0.00%> (+2.27%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981f09b...0de8cab. Read the comment docs.

[sadpandajoe]

🏷️ preset:2022.11