Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove remove SQLALCHEMY_DOCS_URL and SQLALCHEMY_DISPLAY_TEXT from the config from the config #19146

Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 15, 2022

SUMMARY

Removing SQLALCHEMY_DOCS_URL and SQLALCHEMY_DISPLAY_TEXT from the config and allow it to be configured via superset_text.yaml only.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@hughhhh hughhhh force-pushed the hxgh/sc-39227/2-0-remove-sqlalchemy-docs-url-and-sqlalchemy branch from 03ad46b to e1b6847 Compare March 15, 2022 00:19
@hughhhh hughhhh force-pushed the hxgh/sc-39227/2-0-remove-sqlalchemy-docs-url-and-sqlalchemy branch from e1b6847 to 38a3540 Compare March 15, 2022 00:20
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #19146 (d47031c) into master (d01fdad) will increase coverage by 14.35%.
The diff coverage is 0.00%.

❗ Current head d47031c differs from pull request most recent head 2a1283e. Consider uploading reports for the commit 2a1283e to get more accurate results

@@             Coverage Diff             @@
##           master   #19146       +/-   ##
===========================================
+ Coverage   52.03%   66.38%   +14.35%     
===========================================
  Files        1646     1646               
  Lines       63635    63637        +2     
  Branches     6475     6476        +1     
===========================================
+ Hits        33112    42247     +9135     
+ Misses      28843    19708     -9135     
- Partials     1680     1682        +2     
Flag Coverage Δ
hive ?
mysql 81.87% <ø> (?)
postgres 81.92% <ø> (?)
presto ?
python 82.01% <ø> (+29.21%) ⬆️
sqlite 81.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...RUD/data/database/DatabaseModal/SqlAlchemyForm.tsx 57.14% <0.00%> (-9.53%) ⬇️
superset/config.py 91.74% <ø> (+0.26%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
...frontend/src/components/TimezoneSelector/index.tsx 93.93% <0.00%> (-2.94%) ⬇️
superset-frontend/src/views/CRUD/utils.tsx 62.71% <0.00%> (-2.25%) ⬇️
...perset-frontend/src/views/components/MenuRight.tsx 65.71% <0.00%> (ø)
superset/common/utils/query_cache_manager.py 89.41% <0.00%> (+1.17%) ⬆️
superset/initialization/__init__.py 90.72% <0.00%> (+1.71%) ⬆️
superset/extensions.py 93.90% <0.00%> (+2.43%) ⬆️
... and 287 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01fdad...2a1283e. Read the comment docs.

@hughhhh hughhhh force-pushed the hxgh/sc-39227/2-0-remove-sqlalchemy-docs-url-and-sqlalchemy branch from 38a3540 to bba129f Compare March 15, 2022 02:58
@hughhhh hughhhh changed the title chore: Remove remove SQLALCHEMY_DOCS_URL and SQLALCHEMY_DISPLAY_TEXT from the config from the config chore!: Remove remove SQLALCHEMY_DOCS_URL and SQLALCHEMY_DISPLAY_TEXT from the config from the config Mar 15, 2022
@hughhhh hughhhh added the v2.0 label Mar 15, 2022
…/sc-39227/2-0-remove-sqlalchemy-docs-url-and-sqlalchemy
…/sc-39227/2-0-remove-sqlalchemy-docs-url-and-sqlalchemy
@hughhhh hughhhh merged commit 3230415 into master Mar 17, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the hxgh/sc-39227/2-0-remove-sqlalchemy-docs-url-and-sqlalchemy branch March 26, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants