fix(sql lab): deleting the last saved query or the last executed from history #19225

diegomedina248 · 2022-03-16T20:30:27Z

SUMMARY

When the SQL Lab has the persistence enabled on the backend (SQLLAB_BACKEND_PERSISTENCE), the queries failed on delete in two cases:

From the Query History tab, if the query was the last executed.
From the Saved queries, if the query was the last executed in a tab.

The issue is rooted in the TabState table, which has a foreign key to the saved query and to the latest executed one.
So, we need to clear that relation before deleting the query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Query History

Before:

CleanShot.2021-05-19.at.22.12.13.mp4

After:

Screen.Recording.2022-03-16.at.17.27.35.mov

Saved Query

Before:

Saved.query.mp4

After:

Screen.Recording.2022-03-16.at.17.28.42.mov

TESTING INSTRUCTIONS

Saved query:

Go to SQL editor
Input a valid sql query using examples or your own db
Run query and Save as a new query (don't close the saved query tab in SQL editor)
Go to "Saved queries" page
Try to delete the saved query
See the error

Query History:

In SQL editor, run query
Navigate to query history
Click on trash icon

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

diegomedina248 · 2022-03-17T02:38:19Z

superset/views/sql_lab.py

+        # Before deleting the query, ensure it's not tied to any
+        # active tab as the last query. If so, replace the query
+        # with the latest one created in that tab
+        tab_state_query = db.session.query(TabState).filter_by(


We could also set the latest_query_id to NULL, the same as saved_query_id, if we don't care about reassign the latest query.

rusackas · 2022-03-17T02:40:20Z

Pinging @ktmud for 👀 on this one since he's looking at permanently enabling the SQLLAB_BACKEND_PERSISTENCE flag in #18898 so this may affect that.

AAfghahi · 2022-03-17T17:30:56Z

This looks good! Ping me when the tests are passing because I wanna do some frontend testing on it :)

…d query

codecov · 2022-03-17T20:03:45Z

Codecov Report

Merging #19225 (5cd81c7) into master (51061f0) will decrease coverage by 0.17%.
The diff coverage is 33.33%.

❗ Current head 5cd81c7 differs from pull request most recent head a1e2c11. Consider uploading reports for the commit a1e2c11 to get more accurate results

@@            Coverage Diff             @@
##           master   #19225      +/-   ##
==========================================
- Coverage   66.76%   66.59%   -0.18%     
==========================================
  Files        1670     1670              
  Lines       64392    64397       +5     
  Branches     6499     6499              
==========================================
- Hits        42991    42884     -107     
- Misses      19718    19830     +112     
  Partials     1683     1683

Flag	Coverage Δ
hive	`?`
mysql	`81.96% <33.33%> (-0.01%)`	⬇️
postgres	`82.01% <33.33%> (-0.01%)`	⬇️
presto	`?`
python	`82.09% <33.33%> (-0.35%)`	⬇️
sqlite	`81.76% <33.33%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/sql_lab.py	`59.33% <20.00%> (-1.36%)`	⬇️
superset/models/sql_lab.py	`91.55% <100.00%> (ø)`
superset/db_engines/hive.py	`0.00% <0.00%> (-85.19%)`	⬇️
superset/db_engine_specs/hive.py	`70.00% <0.00%> (-15.77%)`	⬇️
superset/db_engine_specs/presto.py	`83.47% <0.00%> (-5.65%)`	⬇️
superset/connectors/sqla/models.py	`88.87% <0.00%> (-1.24%)`	⬇️
superset/db_engine_specs/base.py	`89.14% <0.00%> (-0.34%)`	⬇️
superset/models/core.py	`88.80% <0.00%> (-0.24%)`	⬇️
superset/utils/core.py	`90.13% <0.00%> (-0.13%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51061f0...a1e2c11. Read the comment docs.

AAfghahi · 2022-03-17T20:31:37Z

/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=True

github-actions · 2022-03-17T20:33:25Z

@AAfghahi Ephemeral environment spinning up at http://54.218.227.72:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

AAfghahi

Great work, thank you!

github-actions · 2022-03-17T21:01:40Z

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe · 2022-03-31T02:39:21Z

🏷️ preset:2022.11

… history (#19225) * fix: fix issue when deleting the last saved query or the last executed query * merge migration (cherry picked from commit aa5c80b)

superset-github-bot bot added the Preset-Patch label Mar 16, 2022

pull-request-size bot added the size/L label Mar 16, 2022

diegomedina248 force-pushed the fix/sql-lab-delete-saved-history-query branch from 1972421 to 04550d3 Compare March 17, 2022 02:37

diegomedina248 requested a review from a team as a code owner March 17, 2022 02:37

pull-request-size bot added size/M and removed size/L labels Mar 17, 2022

diegomedina248 commented Mar 17, 2022

View reviewed changes

rusackas requested a review from ktmud March 17, 2022 02:40

diegomedina248 force-pushed the fix/sql-lab-delete-saved-history-query branch from 04550d3 to 776a96f Compare March 17, 2022 02:41

eschutho requested a review from AAfghahi March 17, 2022 17:23

fix: fix issue when deleting the last saved query or the last execute…

159354d

…d query

diegomedina248 force-pushed the fix/sql-lab-delete-saved-history-query branch from 776a96f to db20638 Compare March 17, 2022 19:45

merge migration

a1e2c11

diegomedina248 force-pushed the fix/sql-lab-delete-saved-history-query branch from db20638 to a1e2c11 Compare March 17, 2022 20:08

AAfghahi approved these changes Mar 17, 2022

View reviewed changes

rusackas merged commit aa5c80b into apache:master Mar 17, 2022

villebro added the lts-v1 label Mar 29, 2022

superset-github-bot bot added the preset:2022.11 label Mar 31, 2022

mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 labels Mar 13, 2024

mistercrunch added 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(sql lab): deleting the last saved query or the last executed from history #19225

fix(sql lab): deleting the last saved query or the last executed from history #19225

diegomedina248 commented Mar 16, 2022

diegomedina248 Mar 17, 2022

rusackas commented Mar 17, 2022

AAfghahi commented Mar 17, 2022

codecov bot commented Mar 17, 2022 •

edited

Loading

AAfghahi commented Mar 17, 2022

github-actions bot commented Mar 17, 2022

AAfghahi left a comment

github-actions bot commented Mar 17, 2022

sadpandajoe commented Mar 31, 2022

fix(sql lab): deleting the last saved query or the last executed from history #19225

fix(sql lab): deleting the last saved query or the last executed from history #19225

Conversation

diegomedina248 commented Mar 16, 2022

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Query History

Saved Query

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

diegomedina248 Mar 17, 2022

Choose a reason for hiding this comment

rusackas commented Mar 17, 2022

AAfghahi commented Mar 17, 2022

codecov bot commented Mar 17, 2022 • edited Loading

Codecov Report

AAfghahi commented Mar 17, 2022

github-actions bot commented Mar 17, 2022

AAfghahi left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 17, 2022

sadpandajoe commented Mar 31, 2022

codecov bot commented Mar 17, 2022 •

edited

Loading