Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove PUBLIC_ROLE_LIKE_GAMMA deprecated config key #19274

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

dpgaspar
Copy link
Member

SUMMARY

Completely removed PUBLIC_ROLE_LIKE_GAMMA config key from the code base.

ADDITIONAL INFORMATION

  • Has associated issue: [2.0] Remove PUBLIC_ROLE_LIKE_GAMMA #18900
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar added v2.0 risk:breaking-change Issues or PRs that will introduce breaking changes labels Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #19274 (7068306) into master (783168e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7068306 differs from pull request most recent head 77dadeb. Consider uploading reports for the commit 77dadeb to get more accurate results

@@            Coverage Diff             @@
##           master   #19274      +/-   ##
==========================================
- Coverage   66.57%   66.56%   -0.01%     
==========================================
  Files        1667     1667              
  Lines       64418    64415       -3     
  Branches     6503     6503              
==========================================
- Hits        42886    42881       -5     
- Misses      19849    19851       +2     
  Partials     1683     1683              
Flag Coverage Δ
hive 52.70% <100.00%> (+<0.01%) ⬆️
mysql 81.57% <100.00%> (+<0.01%) ⬆️
postgres 81.60% <100.00%> (-0.01%) ⬇️
presto 52.54% <100.00%> (+<0.01%) ⬆️
python 82.02% <100.00%> (-0.01%) ⬇️
sqlite 81.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 95.10% <ø> (+0.37%) ⬆️
superset/views/core.py 75.87% <100.00%> (ø)
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/common/query_object.py 95.18% <0.00%> (-0.54%) ⬇️
superset/reports/commands/execute.py 91.14% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783168e...77dadeb. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@dpgaspar dpgaspar merged commit af91a13 into apache:master Mar 21, 2022
@dpgaspar dpgaspar deleted the chore/public-role-like-gamma branch March 21, 2022 14:57
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
ukanga added a commit to onaio/helm-chart-superset that referenced this pull request Oct 24, 2022
ukanga added a commit to onaio/helm-chart-superset that referenced this pull request Oct 25, 2022
ukanga added a commit to onaio/helm-chart-superset that referenced this pull request Oct 27, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io risk:breaking-change Issues or PRs that will introduce breaking changes size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants