Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: number format should editable in time comparison #19351

Merged
merged 1 commit into from Mar 24, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Mar 24, 2022

SUMMARY

Currently, users are unable to edit Y axis format when they use time compare and set compare type to percentage. This PR unlock the y axis format selection and filtered percentage fomatter.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

Before

image

TESTING INSTRUCTIONS

  1. Charting a echart version timeseries chart
  2. add a metric in metics control
  3. Select Time shift duration in time comparison panel
  4. Select pecentage change
  5. Run query
  6. Switch to customize panel
  7. Verify the Y axis format can be switching and corresponding formatting applies to the chart.
  8. Y axis format control is able to input user defined formatter as well.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #19351 (413c62c) into master (9766726) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #19351      +/-   ##
==========================================
- Coverage   66.65%   66.64%   -0.01%     
==========================================
  Files        1674     1674              
  Lines       64631    64632       +1     
  Branches     6503     6503              
==========================================
  Hits        43077    43077              
- Misses      19868    19869       +1     
  Partials     1686     1686              
Flag Coverage Δ
javascript 51.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 36.19% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9766726...413c62c. Read the comment docs.

@zhaoyongjie zhaoyongjie changed the title fix: number format should editable when AA in time comparison fix: number format should editable in time comparison Mar 24, 2022
@zhaoyongjie zhaoyongjie requested review from rusackas, jinghua-qa and a team March 24, 2022 13:27
@jinghua-qa jinghua-qa added the need:qa-review Requires QA review label Mar 24, 2022
@zhaoyongjie zhaoyongjie merged commit e15573d into apache:master Mar 24, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 need:qa-review Requires QA review size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants