fix: request samples with default row limit #19456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
approved these changes
Mar 31, 2022
villebro
force-pushed
the
villebro/samples_limit
branch
from
4c12b2f
to
cf1b4e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #19456 +/- ##
=======================================
Coverage 66.58% 66.58%
=======================================
Files 1676 1676
Lines 64176 64181 +5
Branches 6525 6525
=======================================
+ Hits 42732 42737 +5
Misses 19745 19745
Partials 1699 1699
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
added a commit
that referenced
this pull request
Apr 3, 2022
* fix: request samples with default row limit * lodashLint * fix cypress test (cherry picked from commit d684ad0)
villebro
added a commit
that referenced
this pull request
Apr 4, 2022
* fix: request samples with default row limit * lodashLint * fix cypress test (cherry picked from commit d684ad0)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 6, 2022
* fix: request samples with default row limit * lodashLint * fix cypress test (cherry picked from commit d684ad0)
|
🏷️ preset:2022.13 |
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* fix: request samples with default row limit * lodashLint * fix cypress test
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently samples are requested with the original row limit, which tends to be 10k. However, samples should by default return 1k rows. This changes the frontend logic to remove
row_limitandrow_offsetfrom the requested query object so the backend can use the appropriate defaults. The reason this is done in the frontend is to ensure that it's still possible to paginate samples requests if needed. Also clean up some incorrect types + add__future__annotations for cleaner python sig types.AFTER
After the change the samples tab only displays 1k rows
BEFORE
Previously it would request 10k rows if the row limit control was set to 10k:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION