chore: Remove FilterBox.less #19462
Merged
chore: Remove FilterBox.less #19462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geido
commented
Apr 1, 2022
| @@ -409,37 +439,56 @@ class FilterBox extends React.PureComponent { | |||
| return filtersFields.map(filterConfig => { | |||
| const { label, key } = filterConfig; | |||
| return ( | |||
| <div key={key} className="m-b-5 filter-container"> | |||
| <StyledFilterContainer key={key} className="filter-container"> | |||
There was a problem hiding this comment.
This className is used by other less files. We should probably remove it once all the less files have been removed from the codebase
Codecov Report
@@ Coverage Diff @@
## master #19462 +/- ##
==========================================
+ Coverage 66.57% 66.68% +0.10%
==========================================
Files 1675 1678 +3
Lines 64092 64231 +139
Branches 6519 6561 +42
==========================================
+ Hits 42672 42833 +161
+ Misses 19729 19705 -24
- Partials 1691 1693 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/visualizations/FilterBox/FilterBox.test.jsx
Outdated
Show resolved
Hide resolved
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* Remove FilterBox less * Fix test * Add theme top level * Use styledMount
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes the FilterBox.less file from the FilterBox component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual changes
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION