refactor: Removes the CSS files from the Partition plugin #19521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19521 +/- ##
==========================================
+ Coverage 66.59% 66.64% +0.04%
==========================================
Files 1678 1681 +3
Lines 64242 64255 +13
Branches 6539 6561 +22
==========================================
+ Hits 42784 42822 +38
+ Misses 19763 19732 -31
- Partials 1695 1701 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -274,7 +273,7 @@ function Icicle(element, props) { | |||
| '<tr>' + | |||
| '<td>' + | |||
| '<div ' + | |||
| `style='border: 2px solid ${atNode ? 'black' : 'transparent'};` + | |||
| `style='border: 2px solid ${atNode ? 'white' : 'transparent'};` + | |||
There was a problem hiding this comment.
@michael-s-molina should we use the available white from the theme vars?
There was a problem hiding this comment.
Nice catch! I removed the condition and used the transparent border to always show the partition's colors. Previously, when the user was hovering over a partition, the leaf was white. Now the leaf obeys the color of the partition. I think it's more intuitive.
* refactor: Removes the CSS files from the Partition plugin * Fixes bullet * Always use the color of the partitions
mistercrunch
added
🏷️ bot
SUMMARY
This PR removes the CSS files from the Partition plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.
ADDITIONAL INFORMATION