-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deactivate embedding on a dashboard #19626
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19626 +/- ##
===========================================
- Coverage 66.65% 53.85% -12.81%
===========================================
Files 1680 1681 +1
Lines 64277 64371 +94
Branches 6564 6583 +19
===========================================
- Hits 42844 34665 -8179
- Misses 19731 28025 +8294
+ Partials 1702 1681 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* fix tests * commit it properly * unnecessary commit, correct type in docstring * unused import
SUMMARY
Deletion wasn't getting committed properly. The DAO method calls
commit()
, so switched to that.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION