Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up dynamic translation strings #19641

Merged
merged 1 commit into from
Apr 11, 2022
Merged

chore: clean up dynamic translation strings #19641

merged 1 commit into from
Apr 11, 2022

Conversation

villebro
Copy link
Member

SUMMARY

Fix some translations that include variables in the translation string (see here for details why this doesn't work: https://stackoverflow.com/questions/34579316/flask-babel-how-to-translate-variables)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

zhaoyongjie
zhaoyongjie approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit f21ba68 into apache:master Apr 11, 2022
@villebro villebro deleted the villebro/translation-cleanup branch April 11, 2022 10:02
@stephenLYZ stephenLYZ mentioned this pull request Apr 24, 2022
Merged
9 tasks
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@villebro @philipher29
chore: clean up dynamic translation strings (apache#19641)
8b16419
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@villebro @zhaoyongjie @mistercrunch