fix: login button does not render #19685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
force-pushed
the
villebro/isUserAdmin
branch
2 times, most recently
from
c26d980
to
b87d364
Compare
villebro
force-pushed
the
villebro/isUserAdmin
branch
from
b87d364
to
a21ddaf
Compare
Codecov Report
@@ Coverage Diff @@
## master #19685 +/- ##
==========================================
- Coverage 66.50% 66.50% -0.01%
==========================================
Files 1683 1684 +1
Lines 64520 64525 +5
Branches 6607 6612 +5
==========================================
+ Hits 42910 42913 +3
Misses 19916 19916
- Partials 1694 1696 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kgabryje
approved these changes
Apr 13, 2022
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 13, 2022
* fix: login button does not render * add type guard (cherry picked from commit 2ba484f)
|
🏷️ preset:2022.15 |
michael-s-molina
pushed a commit
that referenced
this pull request
May 27, 2022
* fix: login button does not render * add type guard
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* fix: login button does not render * add type guard
mistercrunch
added
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
PR #19051 caused a regression causing the welcome page to fail to render for anonymous users. This adds a new type
UndefinedUser(an empty object), adds type guards for bothUserandUserWithPermissionsAndRolesand updates related functions based on the following comment:superset/superset-frontend/src/dashboard/util/findPermission.test.ts
Lines 137 to 138 in 6e8e29c
In addition, tests are added to ensure
isAdminUserworks for all relevant user types.AFTER
Now the welcome page renders correctly:
BEFORE
When going to the main page without being logged in, the following appears:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION