Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping shillelagh #19726

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

AAfghahi
Copy link
Member

SUMMARY

This bumps the minimum version of shillelagh in order to adjust for a new change in how google structures their service update json.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #19726 (4c30da3) into master (c8304a2) will decrease coverage by 0.17%.
The diff coverage is 63.23%.

❗ Current head 4c30da3 differs from pull request most recent head b2b7d36. Consider uploading reports for the commit b2b7d36 to get more accurate results

@@            Coverage Diff             @@
##           master   #19726      +/-   ##
==========================================
- Coverage   66.51%   66.34%   -0.18%     
==========================================
  Files        1684     1686       +2     
  Lines       64559    64589      +30     
  Branches     6626     6635       +9     
==========================================
- Hits        42941    42851      -90     
- Misses      19923    20039     +116     
- Partials     1695     1699       +4     
Flag Coverage Δ
hive ?
mysql 81.95% <80.00%> (+<0.01%) ⬆️
postgres 82.00% <80.00%> (+<0.01%) ⬆️
presto ?
python 82.09% <80.00%> (-0.35%) ⬇️
sqlite 81.76% <80.00%> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-core/src/models/Registry.ts 100.00% <ø> (ø)
...superset-ui-core/src/query/types/PostProcessing.ts 100.00% <ø> (ø)
...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <0.00%> (ø)
...ntend/src/SqlLab/components/QueryHistory/index.tsx 66.66% <ø> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.00% <0.00%> (-0.50%) ⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js 33.15% <ø> (ø)
...rset-frontend/src/components/ReportModal/index.tsx 78.46% <ø> (ø)
superset-frontend/src/explore/constants.ts 100.00% <ø> (ø)
superset-frontend/src/views/components/SubMenu.tsx 85.96% <ø> (ø)
superset/common/query_context_processor.py 90.65% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8304a2...b2b7d36. Read the comment docs.

@hughhhh hughhhh self-requested a review April 14, 2022 20:01
@AAfghahi AAfghahi merged commit 158852d into apache:master Apr 14, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 15, 2022
(cherry picked from commit 158852d)
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.13

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.13 size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants