Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Applitools in Cypress workflow #19734

Closed
wants to merge 38 commits into from
Closed

feat: Add Applitools in Cypress workflow #19734

wants to merge 38 commits into from

Conversation

geido
Copy link
Member

@geido geido commented Apr 15, 2022

SUMMARY

This PR adds a new Github workflow to enable visual regression testing against Cypress.

This is meant to be an initial test of the functionality and it only checks for a few main sections, including:

  • Explore
  • SqlLab
  • Dashboard view
  • Dashboard edit mode
  • Dashboard and Chart lists

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #19734 (fabd5b6) into master (902ac05) will decrease coverage by 11.91%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #19734       +/-   ##
===========================================
- Coverage   66.27%   54.35%   -11.92%     
===========================================
  Files        1712     1712               
  Lines       63957    63957               
  Branches     6720     6720               
===========================================
- Hits        42390    34767     -7623     
- Misses      19859    27482     +7623     
  Partials     1708     1708               
Flag Coverage Δ
hive 53.65% <ø> (ø)
mysql ?
postgres ?
presto 53.50% <ø> (ø)
python 57.70% <ø> (-24.77%) ⬇️
sqlite ?
unit 48.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/upsert.py 0.00% <0.00%> (-89.59%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-89.37%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/databases/commands/test_connection.py 31.42% <0.00%> (-68.58%) ⬇️
superset/datasets/commands/update.py 25.88% <0.00%> (-68.24%) ⬇️
superset/datasets/commands/create.py 30.18% <0.00%> (-67.93%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
... and 265 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902ac05...fabd5b6. Read the comment docs.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 28, 2022
@geido
Copy link
Member Author

geido commented May 5, 2022

Closing in favor of this #19956

@geido geido closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant