Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make CTA text in Alerts & Reports mails configurable #19779

Merged
merged 1 commit into from Jan 10, 2023

Conversation

cemremengu
Copy link
Contributor

SUMMARY

This PR makes call-to-action link text used in Alerts & Reports emails configurable

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me, so I'll approve... just pointing out the risk that if someone actually changes that value in their config, the translations will not likely exist.

@rusackas
Copy link
Member

rusackas commented Jan 6, 2023

Closing/reopening to kick-start CI. Sorry this fell between the couch cushions for so long! Please feel free to nag us more here or on Slack if this happens again! Thank you!

@rusackas rusackas closed this Jan 6, 2023
@rusackas rusackas reopened this Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #19779 (b04eaab) into master (34008f7) will decrease coverage by 10.75%.
The diff coverage is n/a.

❗ Current head b04eaab differs from pull request most recent head e68b86b. Consider uploading reports for the commit e68b86b to get more accurate results

@@             Coverage Diff             @@
##           master   #19779       +/-   ##
===========================================
- Coverage   66.51%   55.75%   -10.76%     
===========================================
  Files        1686     1859      +173     
  Lines       64589    71036     +6447     
  Branches     6635     7766     +1131     
===========================================
- Hits        42959    39605     -3354     
- Misses      19931    29409     +9478     
- Partials     1699     2022      +323     
Flag Coverage Δ
hive ?
mysql ?
postgres ?
presto 52.38% <ø> (-0.17%) ⬇️
python 57.81% <ø> (-24.62%) ⬇️
sqlite ?
unit 51.47% <ø> (+3.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-ui-chart-controls/src/components/MetricOption.tsx 90.90% <ø> (-3.83%) ⬇️
...et-ui-chart-controls/src/components/labelUtils.tsx 100.00% <ø> (ø)
...ckages/superset-ui-chart-controls/src/constants.ts 100.00% <ø> (ø)
...ackages/superset-ui-chart-controls/src/fixtures.ts 100.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...art-controls/src/operators/contributionOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/flattenOperator.ts 100.00% <ø> (ø)
...t-ui-chart-controls/src/operators/pivotOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/prophetOperator.ts 100.00% <ø> (ø)
...-ui-chart-controls/src/operators/renameOperator.ts 100.00% <ø> (ø)
... and 1153 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cemremengu
Copy link
Contributor Author

cemremengu commented Jan 7, 2023

@rusackas no worries, repo is busy like a bee hive already so don't want to ping much. Thanks for your hard work!

@rusackas rusackas merged commit 0b22287 into apache:master Jan 10, 2023
@cemremengu cemremengu deleted the calltoact branch January 10, 2023 18:54
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants