Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing init files #19797

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Conversation

suddjian
Copy link
Member

SUMMARY

Not sure why the lack of these files didn't raise any CI alarms

#19650

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #19797 (e96a3a6) into master (5e468f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19797   +/-   ##
=======================================
  Coverage   66.54%   66.54%           
=======================================
  Files        1692     1692           
  Lines       64775    64775           
  Branches     6661     6661           
=======================================
  Hits        43103    43103           
  Misses      19972    19972           
  Partials     1700     1700           
Flag Coverage Δ
hive 52.85% <ø> (ø)
mysql 81.90% <ø> (ø)
postgres 81.95% <ø> (ø)
presto 52.70% <ø> (ø)
python 82.37% <ø> (ø)
sqlite 81.71% <ø> (ø)
unit 47.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e468f7...e96a3a6. Read the comment docs.

@suddjian suddjian merged commit c763baf into apache:master Apr 20, 2022
@suddjian suddjian deleted the fix/embedded-init branch April 20, 2022 21:26
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants