Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(explore): Frontend implementation of dataset creation from infobox #19855

Merged
merged 58 commits into from
Jun 7, 2022
Merged

feat(explore): Frontend implementation of dataset creation from infobox #19855

merged 58 commits into from
Jun 7, 2022

Commits on Jun 2, 2022

  1. Frontend implementation of create dataset from infobox

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    6487ee4 View commit details
    Browse the repository at this point in the history

  2. Fixed sl_dataset type

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    2675ccb View commit details
    Browse the repository at this point in the history

  3. Fix test

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    0bbb69f View commit details
    Browse the repository at this point in the history

  4. Fixed sl_dataset type (forgot to save)

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    a5688f5 View commit details
    Browse the repository at this point in the history

  5. RTL testing

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    8a3e4aa View commit details
    Browse the repository at this point in the history

  6. Adjusted styling/text on infobox and save dataset modal

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    3e1f913 View commit details
    Browse the repository at this point in the history

  7. Appease lint

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    d4afdfe View commit details
    Browse the repository at this point in the history

  8. Make infobox invisible and fix tests

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    c32412b View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary placeholder

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    83d2173 View commit details
    Browse the repository at this point in the history

  10. Move types to sql lab

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    3430551 View commit details
    Browse the repository at this point in the history

  11. Moved logic into save dataset modal

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    2bdd51a View commit details
    Browse the repository at this point in the history

  12. Change DatasourceMeta type to Dataset

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    fe7085a View commit details
    Browse the repository at this point in the history

  13. Add ExploreDatasource union type to save dataset modal

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    29f74e2 View commit details
    Browse the repository at this point in the history

  14. Get user info from redux inside save dataset modal

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    7aeba6b View commit details
    Browse the repository at this point in the history

  15. Addressed comments

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    1d49ef5 View commit details
    Browse the repository at this point in the history

  16. Adjusting to new query type

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    4c35710 View commit details
    Browse the repository at this point in the history

  17. Fixed save dataset in explore and union type

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    ff63e6a View commit details
    Browse the repository at this point in the history

  18. Added testing

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    d28edf4 View commit details
    Browse the repository at this point in the history

  19. Defined d for queries

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5ec5eed View commit details
    Browse the repository at this point in the history

  20. Remove dataset from SaveDatasetModal

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    65da6ac View commit details
    Browse the repository at this point in the history

  21. Clarify useSelector parameter

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    2ef4ad4 View commit details
    Browse the repository at this point in the history

  22. Fix dndControls union type

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    1729fe7 View commit details
    Browse the repository at this point in the history

  23. Fix shared-controls union type

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    8a45aef View commit details
    Browse the repository at this point in the history

  24. Fix controlPanel union type

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    e4fc404 View commit details
    Browse the repository at this point in the history

  25. Move ExploreRootState to explore type file

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    106609a View commit details
    Browse the repository at this point in the history

  26. Remove unnecessary testing playground

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    4028043 View commit details
    Browse the repository at this point in the history

  27. Move datasource type check in DatasourcePanel to a function

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    a9212ff View commit details
    Browse the repository at this point in the history

  28. Make all sqllab Query imports reference @superset-ui/core Query type

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    eab9fc0 View commit details
    Browse the repository at this point in the history

  29. Deconstruct query props in ResultSet

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    9b14992 View commit details
    Browse the repository at this point in the history

  30. Fix union type in /legacy-plugin-chart-heatmap/src/controlPanel

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    8558460 View commit details
    Browse the repository at this point in the history

  31. Change SaveDatasetModal tests to RTL

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    c1fb8a6 View commit details
    Browse the repository at this point in the history

  32. Cleaned datasourceTypeCheck

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    9d225c4 View commit details
    Browse the repository at this point in the history

  33. Fix infobox styling

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    383ec2e View commit details
    Browse the repository at this point in the history

  34. Fix SaveDatasetModal test

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    a0c771b View commit details
    Browse the repository at this point in the history

  35. Fix query fixture in sqllab and Query type in SaveDatasetModal test

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    bc38438 View commit details
    Browse the repository at this point in the history

  36. Fix Query type and make test query fixture

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    91f06ea View commit details
    Browse the repository at this point in the history

  37. Added columns to Query type, separated results property, created Quer… 

    …yResponse union type, and fixed all types affected
    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    55bb379 View commit details
    Browse the repository at this point in the history

  38. Fixed a couple missed broken types

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    dab90b4 View commit details
    Browse the repository at this point in the history

  39. Added ExploreDatasource to SqlLab type file

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    c560456 View commit details
    Browse the repository at this point in the history

  40. Removed unneeded Query import from DatasourcePanel

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    30f4508 View commit details
    Browse the repository at this point in the history

  41. Address PR comments

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    6ee52ea View commit details
    Browse the repository at this point in the history

  42. Fix columnChoices

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    1773954 View commit details
    Browse the repository at this point in the history

  43. Fix all incorrect column property checks

    @lyndsiWilliams
    lyndsiWilliams committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    20ede6d View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Fix logic on dndGroupByControl

    @lyndsiWilliams
    lyndsiWilliams committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    ccd3e3e View commit details
    Browse the repository at this point in the history

  2. Dry up savedMetrics type check

    @lyndsiWilliams
    lyndsiWilliams committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    a585546 View commit details
    Browse the repository at this point in the history

  3. Fixed TIME_COLUMN_OPTION

    @lyndsiWilliams
    lyndsiWilliams committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    5c93394 View commit details
    Browse the repository at this point in the history

  4. Dried savedMetrics type check even further

    @lyndsiWilliams
    lyndsiWilliams committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b9db9d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2022

  1. Change savedMetricsTypeCheck to defineSavedMetrics

    @lyndsiWilliams
    lyndsiWilliams committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    cea65ce View commit details
    Browse the repository at this point in the history

  2. Change datasourceTypeCheck to isValidDatasourceType

    @lyndsiWilliams
    lyndsiWilliams committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    90c20b2 View commit details
    Browse the repository at this point in the history

  3. Fix Query path in groupByControl

    @lyndsiWilliams
    lyndsiWilliams committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    faac391 View commit details
    Browse the repository at this point in the history

  4. dnd_granularity_sqla now sorts Query types with is_dttm at the top

    @lyndsiWilliams
    lyndsiWilliams committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    ac671a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Fixed/cleaned query sort

    @lyndsiWilliams
    lyndsiWilliams committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    cf12f1d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into lyndsi/create-dataset-from-infobox

    @lyndsiWilliams
    lyndsiWilliams committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    55c3a79 View commit details
    Browse the repository at this point in the history

  3. Add sortedQueryColumns and proper optional chaining to granularity_sqla

    @lyndsiWilliams
    lyndsiWilliams committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    379d9a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Move testQuery to core-ui, add test coverage for Queries in columnCho… 

    …ices
    @lyndsiWilliams
    lyndsiWilliams committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    23923f4 View commit details
    Browse the repository at this point in the history

  2. Moved DEFAULT_METRICS to core-ui and wrote a test for defineSavedMetrics

    @lyndsiWilliams
    lyndsiWilliams committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    430e43b View commit details
    Browse the repository at this point in the history

  3. Add license and clean dataset test object

    @lyndsiWilliams
    lyndsiWilliams committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    054ee97 View commit details
    Browse the repository at this point in the history

  4. Change DatasourceType.Dataset to dataset

    @lyndsiWilliams
    lyndsiWilliams committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    5514305 View commit details
    Browse the repository at this point in the history