-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Making chart update more truthful #19877
fix: Making chart update more truthful #19877
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19877 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 1714 1715 +1
Lines 65027 65075 +48
Branches 6711 6726 +15
=======================================
+ Hits 43250 43284 +34
- Misses 20070 20079 +9
- Partials 1707 1712 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
Outdated
Show resolved
Hide resolved
…sDropdown/index.jsx Co-authored-by: Evan Rusackas <evan@preset.io>
superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
Outdated
Show resolved
Hide resolved
…sDropdown/index.jsx Fixing case
This update is because the charts are still being loaded when the toast message fires. This update makes the message more truthful |
* Update index.jsx * Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx Fixing case Co-authored-by: Evan Rusackas <evan@preset.io>
* Update index.jsx * Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx Fixing case Co-authored-by: Evan Rusackas <evan@preset.io>
SUMMARY
Very small text update
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION