Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Making chart update more truthful #19877

Merged

Conversation

Gwitchr
Copy link
Contributor

@Gwitchr Gwitchr commented Apr 28, 2022

SUMMARY

Very small text update

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Gwitchr Gwitchr changed the title [42258] [42258] Message toast charts update Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #19877 (96eb5c8) into master (481ccfe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19877   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1714     1715    +1     
  Lines       65027    65075   +48     
  Branches     6711     6726   +15     
=======================================
+ Hits        43250    43284   +34     
- Misses      20070    20079    +9     
- Partials     1707     1712    +5     
Flag Coverage Δ
javascript 51.25% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/Header/HeaderActionsDropdown/index.jsx 71.66% <100.00%> (ø)
...tend/src/visualizations/FilterBox/controlPanel.jsx 0.00% <0.00%> (-37.50%) ⬇️
...tend/plugins/plugin-chart-handlebars/src/consts.ts 75.00% <0.00%> (-25.00%) ⬇️
superset-frontend/src/views/store.ts 80.00% <0.00%> (-10.00%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 63.15% <0.00%> (-8.28%) ⬇️
...nts/ExploreAdditionalActionsMenu/ExploreReport.tsx 50.00% <0.00%> (-7.90%) ⬇️
...-ui-chart-controls/src/components/MetricOption.tsx 90.90% <0.00%> (-3.83%) ⬇️
superset-frontend/src/reports/actions/reports.js 36.36% <0.00%> (-3.04%) ⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx 70.49% <0.00%> (-1.18%) ⬇️
...dashboard/components/SliceHeaderControls/index.tsx 66.25% <0.00%> (-0.42%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 481ccfe...96eb5c8. Read the comment docs.

@Gwitchr Gwitchr changed the title [42258] Message toast charts update fix: Message toast charts update [42258] Apr 28, 2022
…sDropdown/index.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>
@rusackas rusackas changed the title fix: Message toast charts update [42258] fix: Making chart update more truthful May 5, 2022
@rusackas
Copy link
Member

rusackas commented May 5, 2022

This update is because the charts are still being loaded when the toast message fires. This update makes the message more truthful

@rusackas rusackas merged commit 35db7fb into apache:master May 10, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
* Update index.jsx

* Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx

Fixing case

Co-authored-by: Evan Rusackas <evan@preset.io>
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Update index.jsx

* Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx

Fixing case

Co-authored-by: Evan Rusackas <evan@preset.io>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants