Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add debug to tables endpoint #19928

Closed
wants to merge 1 commit into from

Conversation

betodealmeida
Copy link
Member

SUMMARY

Add some temporary logging to troubleshoot a problem where tables is returned as a list of lists, for some reason.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #19928 (803a861) into master (1ebdaac) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 803a861 differs from pull request most recent head 55dab89. Consider uploading reports for the commit 55dab89 to get more accurate results

@@            Coverage Diff             @@
##           master   #19928      +/-   ##
==========================================
- Coverage   66.53%   66.53%   -0.01%     
==========================================
  Files        1715     1715              
  Lines       65060    65066       +6     
  Branches     6723     6723              
==========================================
+ Hits        43289    43292       +3     
- Misses      20060    20063       +3     
  Partials     1711     1711              
Flag Coverage Δ
hive 52.89% <0.00%> (-0.01%) ⬇️
mysql 81.94% <66.66%> (-0.01%) ⬇️
postgres 81.98% <66.66%> (-0.01%) ⬇️
presto 52.74% <0.00%> (-0.01%) ⬇️
python 82.40% <66.66%> (-0.01%) ⬇️
sqlite 81.75% <66.66%> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 77.01% <66.66%> (-0.05%) ⬇️
superset/initialization/__init__.py 91.37% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ebdaac...55dab89. Read the comment docs.

@eschutho
Copy link
Member

eschutho commented May 3, 2022

@betodealmeida do you think we still need this?

@betodealmeida
Copy link
Member Author

betodealmeida commented May 3, 2022

I'll keep it open just in case (since the tests are green :-P ), if #19930 solves the problem I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants