Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not correctly set force in store #19932

Merged
merged 2 commits into from May 3, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented May 3, 2022

SUMMARY

The data panel should force query when clicking the force button.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

force.datapanel.mov

Before

data.panel.force.query.before.mov

TESTING INSTRUCTIONS

  1. ensure that the data cache is used in config.py.
  2. make a chart
  3. open inspector in any browser, and switch to the network panel
  4. verify the force=true in both requests when you click the cached button.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #19932 (693aaa2) into master (9328053) will increase coverage by 0.01%.
The diff coverage is 71.42%.

❗ Current head 693aaa2 differs from pull request most recent head 63cef9c. Consider uploading reports for the commit 63cef9c to get more accurate results

@@            Coverage Diff             @@
##           master   #19932      +/-   ##
==========================================
+ Coverage   66.52%   66.53%   +0.01%     
==========================================
  Files        1714     1715       +1     
  Lines       65032    65065      +33     
  Branches     6717     6723       +6     
==========================================
+ Hits        43260    43293      +33     
+ Misses      20065    20061       -4     
- Partials     1707     1711       +4     
Flag Coverage Δ
javascript 51.27% <72.97%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns/legacy-plugin-chart-heatmap/src/controlPanel.ts 66.66% <ø> (ø)
.../legacy-plugin-chart-histogram/src/controlPanel.ts 60.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 100.00% <ø> (ø)
...frontend/plugins/plugin-chart-echarts/src/types.ts 100.00% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 33.15% <ø> (ø)
...nd/src/explore/components/DataTablesPane/index.tsx 71.55% <ø> (ø)
...d/src/explore/components/DatasourcePanel/index.tsx 69.23% <ø> (ø)
.../components/ExploreAdditionalActionsMenu/index.jsx 57.14% <ø> (ø)
...ntend/src/explore/components/ExploreChartPanel.jsx 70.49% <0.00%> (-1.18%) ⬇️
superset-frontend/src/types/bootstrapTypes.ts 100.00% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9328053...63cef9c. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented May 3, 2022

@diegomedina248 a review would be appreciated if you're able

@rusackas rusackas merged commit 24e4ab6 into apache:master May 3, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
* fix: can not correctly set force in store

* fix ut
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* fix: can not correctly set force in store

* fix ut
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants