Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate /superset/testconn and migrate to api v1 #20002

Conversation

zephyring
Copy link
Contributor

@zephyring zephyring commented May 9, 2022

SUMMARY

Following plan to gradually deprecate "REST" endpoints on /superset namespace.

Deprecates /superset/testconn. Proposed removal on Superset 3.0
New endpoint /api/v1/database/test_connection

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-05-09 at 1 48 55 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #20002 (9ca119d) into master (62e1c34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20002   +/-   ##
=======================================
  Coverage   66.28%   66.28%           
=======================================
  Files        1712     1712           
  Lines       63968    63969    +1     
  Branches     6731     6731           
=======================================
+ Hits        42404    42405    +1     
  Misses      19853    19853           
  Partials     1711     1711           
Flag Coverage Δ
hive 53.65% <0.00%> (-0.01%) ⬇️
mysql 81.99% <100.00%> (+<0.01%) ⬆️
postgres 82.04% <100.00%> (+<0.01%) ⬆️
presto 53.51% <0.00%> (-0.01%) ⬇️
python 82.47% <100.00%> (+<0.01%) ⬆️
sqlite 81.78% <100.00%> (+<0.01%) ⬆️
unit 48.63% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 77.38% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e1c34...9ca119d. Read the comment docs.

@dpgaspar dpgaspar merged commit 7b7de95 into apache:master May 10, 2022
@dpgaspar dpgaspar deleted the zef/sc-42055/migrate-superset-test-connection-to-api branch May 10, 2022 20:26
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
* feat: deprecate /superset/testconn and migrate to api v1

* bring back core_tests
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* feat: deprecate /superset/testconn and migrate to api v1

* bring back core_tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants