Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URI form is blank when trying to connect from sql lab #20004

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

The connect a database modal, when in the SQL Lab, is not displaying the information in the URI form.

The reason is that the SQL Lab uses and customizes the antd Tabs component, and by changing the design it also affects this modal.

This PR sets the proper styles for the modal, to set and prevent this issue

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-05-09.at.16.55.42.mov

After:

new.mov

TESTING INSTRUCTIONS

  • Go to sql lab
  • Select the + menu
  • Select the data menu
  • Connect a new database
  • Select a database
  • Switch to the URI form

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #20004 (33f58e4) into master (b7cff83) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 33f58e4 differs from pull request most recent head 17f1398. Consider uploading reports for the commit 17f1398 to get more accurate results

@@           Coverage Diff           @@
##           master   #20004   +/-   ##
=======================================
  Coverage   66.28%   66.28%           
=======================================
  Files        1712     1712           
  Lines       63968    63969    +1     
  Branches     6731     6731           
=======================================
+ Hits        42404    42405    +1     
  Misses      19853    19853           
  Partials     1711     1711           
Flag Coverage Δ
javascript 51.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.69% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7cff83...17f1398. Read the comment docs.

@stephenLYZ stephenLYZ self-requested a review May 10, 2022 10:00
Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@stephenLYZ stephenLYZ merged commit cc026e9 into apache:master May 11, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.19

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.19 Preset-Patch size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants