chore: Removes hard-coded colors - iteration 3

[michael-s-molina]

SUMMARY

Replaces hard-coded colors with colors from the theme.

TESTING INSTRUCTIONS

1 - Execute all tests.
2 - All tests should pass.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20016 (1738fd5) into master (62e1c34) will decrease coverage by 0.01%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##           master   #20016      +/-   ##
==========================================
- Coverage   66.28%   66.27%   -0.02%     
==========================================
  Files        1712     1712              
  Lines       63968    63948      -20     
  Branches     6731     6731              
==========================================
- Hits        42404    42382      -22     
- Misses      19853    19855       +2     
  Partials     1711     1711              

Flag	Coverage Δ
javascript	51.23% <63.15%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rc/SqlLab/components/ScheduleQueryButton/index.tsx	20.75% <0.00%> (ø)
superset-frontend/src/components/Select/styles.tsx	81.13% <ø> (ø)
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx	74.39% <ø> (ø)
...mponents/controls/AnnotationLayerControl/index.jsx	10.16% <0.00%> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx	41.41% <ø> (ø)
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx	52.38% <ø> (ø)
...rontend/src/visualizations/TimeTable/TimeTable.jsx	0.00% <ø> (ø)
...onalFormattingControl/FormattingPopoverContent.tsx	51.35% <25.00%> (-2.94%)	⬇️
superset-frontend/src/components/Tabs/Tabs.tsx	95.83% <50.00%> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx	50.54% <100.00%> (-0.54%)	⬇️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e1c34...1738fd5. Read the comment docs.

[stevetracvc]

This broke the conditional color formatting in tables, at least for me.
FormattingPopoverContent.tsx used to be

const colorSchemeOptions = [
  { value: 'rgb(0,255,0)', label: t('green') },
  { value: 'rgb(255,255,0)', label: t('yellow') },
  { value: 'rgb(255,0,0)', label: t('red') },
];

and now all of those values are hex strings instead.

[michael-s-molina]

This broke the conditional color formatting in tables, at least for me.

Thanks for raising this @stevetracvc and for submitting a PR to fix it.