Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): transparent linear gradient not working in safari #20086

Merged
merged 2 commits into from
May 24, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented May 16, 2022

SUMMARY

This PR fixes the problem that transparent linear gradient not working in safari. refer to https://css-tricks.com/thing-know-gradients-transparent-black/.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

image

after

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #20086 (3c94e02) into master (9854d2d) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20086      +/-   ##
==========================================
- Coverage   66.37%   66.34%   -0.04%     
==========================================
  Files        1715     1716       +1     
  Lines       64179    64311     +132     
  Branches     6753     6811      +58     
==========================================
+ Hits        42602    42665      +63     
- Misses      19859    19913      +54     
- Partials     1718     1733      +15     
Flag Coverage Δ
javascript 51.32% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 85.71% <ø> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 79.80% <ø> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/index.ts 25.00% <0.00%> (-25.00%) ⬇️
...tend/plugins/plugin-chart-echarts/src/controls.tsx 56.66% <0.00%> (-17.25%) ⬇️
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 86.66% <0.00%> (-6.20%) ⬇️
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 34.48% <0.00%> (-5.52%) ⬇️
...d/plugins/plugin-chart-echarts/src/utils/series.ts 87.50% <0.00%> (-5.46%) ⬇️
...end/src/components/Datasource/DatasourceEditor.jsx 65.20% <0.00%> (-4.17%) ⬇️
...t-frontend/src/dashboard/components/SliceAdder.jsx 66.17% <0.00%> (-3.18%) ⬇️
...rset-frontend/src/explore/exploreUtils/formData.ts 85.71% <0.00%> (-3.18%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9854d2d...3c94e02. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know we were already using that emotion-rgba lib. Nifty!

@stephenLYZ stephenLYZ merged commit ce01ce9 into apache:master May 24, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…0086)

* fix(css): transparent linear gradient not working in safari

* use emotion-rgba instead
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native-filter] The bottom of the left sidebar looks weird in the safari.
3 participants