Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(typo): occured -> occurred #20116

Merged
merged 6 commits into from
Jun 20, 2022
Merged

style(typo): occured -> occurred #20116

merged 6 commits into from
Jun 20, 2022

Conversation

sfirke
Copy link
Member

@sfirke sfirke commented May 18, 2022

SUMMARY

Changed the 4 instance of "occured" in error messages to "occurred", the conventional spelling which appears 82 times in the repo currently.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #20116 (7033cc1) into master (1fe30f1) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20116      +/-   ##
==========================================
+ Coverage   66.46%   66.71%   +0.24%     
==========================================
  Files        1721     1739      +18     
  Lines       64467    65161     +694     
  Branches     6795     6899     +104     
==========================================
+ Hits        42847    43469     +622     
- Misses      19892    19939      +47     
- Partials     1728     1753      +25     
Flag Coverage Δ
hive 53.70% <ø> (+0.01%) ⬆️
javascript 51.76% <100.00%> (+0.40%) ⬆️
mysql 82.26% <ø> (+0.12%) ⬆️
postgres 82.33% <ø> (+0.14%) ⬆️
presto 53.56% <ø> (+0.01%) ⬆️
python 82.76% <ø> (+0.15%) ⬆️
sqlite 82.12% <ø> (+0.18%) ⬆️
unit 50.55% <ø> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ui-core/src/chart/components/FallbackComponent.tsx 100.00% <ø> (ø)
...t-frontend/src/dashboard/actions/dashboardState.js 36.54% <100.00%> (ø)
...oard/components/gridComponents/new/NewMarkdown.jsx 0.00% <0.00%> (-100.00%) ⬇️
...s/legacy-plugin-chart-sunburst/src/controlPanel.ts 20.00% <0.00%> (-80.00%) ⬇️
...s/plugin-chart-echarts/src/BoxPlot/controlPanel.ts 25.00% <0.00%> (-75.00%) ⬇️
.../legacy-plugin-chart-world-map/src/controlPanel.ts 25.00% <0.00%> (-75.00%) ⬇️
.../legacy-preset-chart-nvd3/src/Line/controlPanel.ts 50.00% <0.00%> (-50.00%) ⬇️
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 34.66% <0.00%> (-36.77%) ⬇️
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx 66.66% <0.00%> (-33.34%) ⬇️
.../plugin-chart-echarts/src/Treemap/controlPanel.tsx 66.66% <0.00%> (-33.34%) ⬇️
... and 254 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe30f1...7033cc1. Read the comment docs.

@john-bodley john-bodley merged commit b7eb235 into apache:master Jun 20, 2022
@sfirke sfirke deleted the typo-fix-occured branch June 21, 2022 15:31
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
* Occured -> Occurred

* Occured -> Occurred

* Occured -> Occurred

* Occured - > Occurred

* Update FallbackComponent.tsx

* Update FallbackComponent.tsx

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
(cherry picked from commit b7eb235)
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants