Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Add create chart button in dashboard edit mode #20126

Merged
merged 1 commit into from May 19, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

Clicking on "Create new chart" in "Charts" tab in dashboard edit mode button redirects to /chart/add view in a new tab.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

  1. Go to dashboard edit mode -> Charts tab
  2. Click "Create new chart" button
  3. Verify that you've were redirected to /chart/add page

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @kasiazjc

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #20126 (de2ed22) into master (660af40) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master   #20126      +/-   ##
==========================================
- Coverage   66.47%   66.46%   -0.01%     
==========================================
  Files        1721     1721              
  Lines       64477    64483       +6     
  Branches     6795     6795              
==========================================
+ Hits        42858    42860       +2     
- Misses      19891    19895       +4     
  Partials     1728     1728              
Flag Coverage Δ
javascript 51.35% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/dashboard/components/SliceAdder.jsx 66.17% <33.33%> (-3.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660af40...de2ed22. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

buttonStyle="link"
buttonSize="xsmall"
onClick={() =>
window.open('/chart/add', '_blank', 'noopener noreferrer')
Copy link
Member

@villebro villebro May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be interesting to implement broadcasting so that the list is updated when a chart is created: https://developer.mozilla.org/en-US/docs/Web/API/Broadcast_Channel_API

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! But wouldn't we actually need to use websocket instead to update the list when chart is saved on the backend? I just wonder if such frontend communication would be reliable enough

@kgabryje kgabryje merged commit b2a7fad into apache:master May 19, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants