Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: superset-ui/core coverage #20324

Merged
merged 1 commit into from Jun 9, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jun 9, 2022

SUMMARY

fix superset-ui/core codes coverage and enabled coverage output in the terminal.

Test this PR by following command

cd superset-frontend
rm -rf coverage
npx jest --coverage --collectCoverageFrom='["packages/**/src/**/*.{js,ts}", "!packages/superset-ui-demo/**/*"]' packages

image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #20324 (0a288b5) into master (fd12987) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20324   +/-   ##
=======================================
  Coverage   66.56%   66.56%           
=======================================
  Files        1738     1738           
  Lines       65025    65028    +3     
  Branches     6883     6884    +1     
=======================================
+ Hits        43281    43287    +6     
  Misses      19994    19994           
+ Partials     1750     1747    -3     
Flag Coverage Δ
javascript 51.65% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/superset-ui-core/src/query/types/Dashboard.ts 100.00% <ø> (ø)
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <100.00%> (ø)
...erset-ui-chart-controls/src/utils/columnChoices.ts 100.00% <100.00%> (+20.00%) ⬆️
...-ui-chart-controls/src/utils/defineSavedMetrics.ts 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd12987...0a288b5. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhaoyongjie zhaoyongjie merged commit d04357c into apache:master Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants