fix: catch some potential errors on dual write #20351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
commented
Jun 11, 2022
| items = set(session) | ||
| except ObjectDeletedError: | ||
| logger.warning("ObjectDeletedError", exc_info=True) | ||
| return iter(()) |
There was a problem hiding this comment.
this was erroring for me when running integration tests, so I just thought it would be safe to catch and log the error in case it happens in the real world.
Codecov Report
@@ Coverage Diff @@
## master #20351 +/- ##
==========================================
+ Coverage 66.49% 66.51% +0.02%
==========================================
Files 1734 1738 +4
Lines 64996 65097 +101
Branches 6871 6885 +14
==========================================
+ Hits 43219 43302 +83
- Misses 20020 20047 +27
+ Partials 1757 1748 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
force-pushed
the
elizabeth/fix-update-bug
branch
from
be542dd
to
baa5cd8
Compare
hughhhh
approved these changes
Jun 13, 2022
AAfghahi
approved these changes
Jun 13, 2022
eschutho
force-pushed
the
elizabeth/fix-update-bug
branch
from
437416a
to
4efb13a
Compare
|
🏷️ preset:2022.23 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 14, 2022
* catch some potential errors on dual write * fix test for sqlite (cherry picked from commit 5a13782)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 14, 2022
* catch some potential errors on dual write * fix test for sqlite (cherry picked from commit 5a13782)
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're seeing some errors when trying to import a dashboard:
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint "sl_columns_uuid_key"The issue is intermittent, and I was only able to replicate in a test by making the lookup for aNewColumnreturn none. I added in a catch for that scenario and also changed the sessionaddtomergeto take a safer route in case SqlAlchemy is trying to add rather than update in some cases.TESTING INSTRUCTIONS
difficult to reproduce, but regression testing should apply: you should be able to update datasets, columns, etc with no errors.
ADDITIONAL INFORMATION