Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL #20385

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/key_value/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class KeyValueEntry(Model, AuditMixinNullable, ImportExportMixin):
__tablename__ = "key_value"
id = Column(Integer, primary_key=True)
resource = Column(String(32), nullable=False)
value = Column(LargeBinary(), nullable=False)
value = Column(LargeBinary(length=2**24 - 1), nullable=False)
created_on = Column(DateTime, nullable=True)
created_by_fk = Column(Integer, ForeignKey("ab_user.id"), nullable=True)
changed_on = Column(DateTime, nullable=True)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""Resize key_value blob

Revision ID: e09b4ae78457
Revises: e786798587de
Create Date: 2022-06-14 15:28:42.746349

"""

# revision identifiers, used by Alembic.
revision = "e09b4ae78457"
down_revision = "e786798587de"

from alembic import op
import sqlalchemy as sa


def upgrade():
with op.batch_alter_table("key_value", schema=None) as batch_op:
batch_op.alter_column(
"value",
existing_nullable=False,
existing_type=sa.LargeBinary(),
type_=sa.LargeBinary(length=2**24 - 1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep this in line with #19805, should we make it length=2**31?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@villebro aren't we over provisioning the column if we opt for ~ 2 GiB as opposed to 16 MiB? Maybe per #19805 the existing_type should be sa.LargeBinary(length=2**31)—and something similar in the downgrade.

)


def downgrade():
with op.batch_alter_table("key_value", schema=None) as batch_op:
batch_op.alter_column(
"value",
existing_nullable=False,
existing_type=sa.LargeBinary(length=2**24 - 1),
type_=sa.LargeBinary(),
)