Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting db UUID #20412

Merged
merged 4 commits into from
Jun 16, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

Allow client to specify an UUID when creating a database.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

I added a unit test. I also refactored some logic into a full_api_access fixture that helps write integration tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida changed the title Allow setting db UUID feat: allow setting db UUID Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #20412 (ce00b43) into master (cb2ffa5) will decrease coverage by 11.69%.
The diff coverage is 77.47%.

❗ Current head ce00b43 differs from pull request most recent head b352636. Consider uploading reports for the commit b352636 to get more accurate results

@@             Coverage Diff             @@
##           master   #20412       +/-   ##
===========================================
- Coverage   66.63%   54.94%   -11.70%     
===========================================
  Files        1738     1739        +1     
  Lines       65078    65136       +58     
  Branches     6885     6897       +12     
===========================================
- Hits        43367    35788     -7579     
- Misses      19963    27595     +7632     
- Partials     1748     1753        +5     
Flag Coverage Δ
hive 53.70% <44.44%> (-0.02%) ⬇️
mysql ?
presto 53.56% <44.44%> (-0.02%) ⬇️
python 58.37% <55.55%> (-24.34%) ⬇️
sqlite ?
unit 50.54% <55.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...art-controls/src/operators/contributionOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/flattenOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/prophetOperator.ts 100.00% <ø> (ø)
...i-chart-controls/src/operators/resampleOperator.ts 100.00% <ø> (ø)
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 65.00% <ø> (ø)
...gins/plugin-chart-echarts/src/Pie/controlPanel.tsx 28.57% <0.00%> (-4.77%) ⬇️
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 33.33% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 33.33% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 33.33% <ø> (ø)
...rt-echarts/src/Timeseries/Regular/controlPanel.tsx 33.33% <ø> (ø)
... and 319 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2ffa5...b352636. Read the comment docs.

@eschutho
Copy link
Member

@betodealmeida does this need a migration or is it just an in-memory sqlalchemy construct?

@betodealmeida
Copy link
Member Author

@betodealmeida does this need a migration or is it just an in-memory sqlalchemy construct?

No migration needed, we're just changing the payload schema to allow an optional UUID.

@betodealmeida betodealmeida merged commit 998624b into apache:master Jun 16, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
* WIP

* feat: allow passing UUID when creating a DB

* Test

* Fix field
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants