fix: should raise exception when apply a categorical axis #20451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 23, 2022
(cherry picked from commit 8bbbd6f)
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 28, 2022
(cherry picked from commit 8bbbd6f)
mistercrunch
reviewed
Jul 5, 2022
| @@ -322,6 +322,16 @@ def processing_time_offsets( # pylint: disable=too-many-locals | |||
| # multi-dimensional charts | |||
| granularity = query_object.granularity | |||
| index = granularity if granularity in df.columns else DTTM_ALIAS | |||
| if not pd.api.types.is_datetime64_any_dtype( | |||
There was a problem hiding this comment.
Based on recent errors I'm guessing this is too restrictive.
There was a problem hiding this comment.
Guessing this should be is_datetime64_any_dtype(...) or is_datetime64tz_any_dtype(...)
There was a problem hiding this comment.
is_datetime64_any_dtype verify is_datetime64tz_any_dtype as well, https://github.com/pandas-dev/pandas/blob/e8093ba372f9adfe79439d90fe74b0b5b6dea9d6/pandas/core/dtypes/common.py#L922
mistercrunch
added
🍒 2.0.0
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Raise a specified error when using categorical x-axis and time comparison.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
Before
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION