Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async queries limit bug #20468

Merged
merged 1 commit into from
Jun 22, 2022
Merged

fix: async queries limit bug #20468

merged 1 commit into from
Jun 22, 2022

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Jun 22, 2022

SUMMARY

Limits that were in the sql statement were not being respected in async queries.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-06-22.at.12.26.45.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi assigned AAfghahi and betodealmeida and unassigned AAfghahi Jun 22, 2022
@AAfghahi AAfghahi changed the title async queries limit bug fix: async queries limit bug Jun 22, 2022
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, Arash!

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #20468 (a8b29d2) into master (cf4f05e) will decrease coverage by 11.81%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #20468       +/-   ##
===========================================
- Coverage   66.72%   54.91%   -11.82%     
===========================================
  Files        1739     1739               
  Lines       65130    65611      +481     
  Branches     6898     6898               
===========================================
- Hits        43459    36028     -7431     
- Misses      19921    27833     +7912     
  Partials     1750     1750               
Flag Coverage Δ
hive 53.62% <100.00%> (-0.12%) ⬇️
postgres ?
presto 53.48% <100.00%> (-0.12%) ⬇️
python 58.21% <100.00%> (-24.59%) ⬇️
sqlite ?
unit 50.38% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sqllab/command.py 86.20% <100.00%> (+0.11%) ⬆️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/upsert.py 0.00% <0.00%> (-89.59%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-89.37%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.88% <0.00%> (-68.24%) ⬇️
superset/datasets/commands/create.py 30.18% <0.00%> (-67.93%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
... and 273 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf4f05e...a8b29d2. Read the comment docs.

@AAfghahi AAfghahi merged commit 2c16be4 into master Jun 22, 2022
@AAfghahi AAfghahi deleted the arash/result-limit-async branch June 22, 2022 20:21
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jun 23, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.25

michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
(cherry picked from commit 2c16be4)
michael-s-molina pushed a commit that referenced this pull request Jun 28, 2022
(cherry picked from commit 2c16be4)
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.25 preset-io size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants