Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] feat: Add pagination to the table selector when adding a dataset #20525

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member

Hi @diegomedina248. This feature was proposed in the past but it was rejected. You can check this discussion for context.

@diegomedina248
Copy link
Contributor Author

Hi @diegomedina248. This feature was proposed in the past but it was rejected. You can check this discussion for context.

Thanks, yeah, this would actually just "mock" the pagination, as the underlying structure doesn't allow pagination (as far as I could tell).
Will close this for now then, since it was discussed. Thanks.

@diegomedina248 diegomedina248 deleted the feat/table-list-pagination branch June 28, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants