Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates Metrics and Columns font-size #20526

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Updates Metrics and Columns font-size to match control headers.

@kasiazjc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-06-28 at 2 56 57 PM

Screen Shot 2022-06-28 at 2 59 06 PM

TESTING INSTRUCTIONS

1 - Go to Explore
2 - Check the new font sizes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #20526 (cd455fa) into master (c348a09) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20526   +/-   ##
=======================================
  Coverage   66.86%   66.86%           
=======================================
  Files        1751     1751           
  Lines       65429    65429           
  Branches     6912     6912           
=======================================
  Hits        43746    43746           
  Misses      19934    19934           
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/explore/components/DatasourcePanel/index.tsx 69.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c348a09...cd455fa. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 4eb2a6f into apache:master Jun 29, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants