Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move isAdhocColumn from controls to core #20529

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

move isAdhocColumn from @superset-ui/controls to @superset-ui/core, no functional changes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/a

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #20529 (c78bb1d) into master (850f5fa) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20529   +/-   ##
=======================================
  Coverage   66.84%   66.84%           
=======================================
  Files        1751     1751           
  Lines       65441    65440    -1     
  Branches     6913     6912    -1     
=======================================
  Hits        43746    43746           
+ Misses      19946    19945    -1     
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/query/types/Column.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/query/types/Metric.ts 100.00% <ø> (ø)
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <ø> (ø)
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 3.75% <ø> (ø)
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx 65.51% <ø> (ø)
.../controls/DndColumnSelectControl/OptionWrapper.tsx 63.41% <ø> (ø)
...hart-controls/src/utils/getStandardizedControls.ts 100.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850f5fa...c78bb1d. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenLYZ stephenLYZ merged commit 927d066 into apache:master Jun 29, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
* chore: move isAdhocColumn to superset-ui/core

* ut
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants