Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve & un-skip flaky Cypress test #20568

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Jun 30, 2022

SUMMARY

This PR adds some resilience to the flaky Cypress test skipped in #20417 (thanks @adam-stasiak!) and un-skips it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Check CI and perhaps try running Cypress locally to make sure tests pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #20568 (41792d9) into master (edb1383) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20568   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        1752     1752           
  Lines       65478    65478           
  Branches     6916     6916           
=======================================
  Hits        43750    43750           
  Misses      19980    19980           
  Partials     1748     1748           
Flag Coverage Δ
javascript 51.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb1383...41792d9. Read the comment docs.

@rusackas rusackas merged commit b99482d into apache:master Jun 30, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants