Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert #20408 (stacking negative values in echarts bar chart) #20571

Merged
merged 1 commit into from Jun 30, 2022

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jun 30, 2022

This reverts commit c959d92.

The PR being reverted bumped echarts and changes the stacking method to allow proper stacking of negative values (cool!). However, if a dataset happens to display null values as bar segments, clicking on the legend causes the chart display to become VERY erratic in terms of what's displayed/hidden in the stacked bars - things disappear completely!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

problem_bar.mp4

After: coming soon... but it works, trust me ;)

TESTING INSTRUCTIONS

Create a dataset with this query

SELECT TO_DATE('2011-01-01', 'yyyy-MM-dd') as d, 1 as city, 1 as count
union all SELECt TO_DATE('2011-01-01', 'yyyy-MM-dd'), 1, 1
union all SELECt TO_DATE('2011-01-01', 'yyyy-MM-dd'), 1, null
union all SELECt TO_DATE('2011-01-01', 'yyyy-MM-dd'), 2, 1
union all SELECt TO_DATE('2011-01-01', 'yyyy-MM-dd'), 2, null
union all SELECt TO_DATE('2012-01-01', 'yyyy-MM-dd'), 2, null
union all SELECt TO_DATE('2013-01-01', 'yyyy-MM-dd'), 2, null
union all SELECt TO_DATE('2013-01-01', 'yyyy-MM-dd'), 2, 1

...then make Timeseries Bar Chart V2 as shown in the GIF. Click around on the labels and see if you see all the right bars at all times.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #20571 (9121108) into master (edb1383) will not change coverage.
The diff coverage is n/a.

❗ Current head 9121108 differs from pull request most recent head 0314543. Consider uploading reports for the commit 0314543 to get more accurate results

@@           Coverage Diff           @@
##           master   #20571   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        1752     1752           
  Lines       65478    65478           
  Branches     6916     6916           
=======================================
  Hits        43750    43750           
  Misses      19980    19980           
  Partials     1748     1748           
Flag Coverage Δ
javascript 51.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb1383...0314543. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rusackas rusackas merged commit f5f8dde into master Jun 30, 2022
@rusackas rusackas deleted the revert-#20408 branch June 30, 2022 19:52
michael-s-molina pushed a commit that referenced this pull request Jul 6, 2022
…itive values (#20408)" (#20571)

This reverts commit c959d92.

(cherry picked from commit f5f8dde)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants