feat: add extension point to the top of welcome page #20575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 30, 2022 14:56
Codecov Report
@@ Coverage Diff @@
## master #20575 +/- ##
=======================================
Coverage 66.79% 66.80%
=======================================
Files 1754 1754
Lines 65561 65577 +16
Branches 6933 6935 +2
=======================================
+ Hits 43793 43809 +16
Misses 20014 20014
Partials 1754 1754
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
suddjian
reviewed
Jul 1, 2022
| @@ -95,6 +95,10 @@ export const URL_PARAMS = { | |||
| name: 'viz_type', | |||
| type: 'string', | |||
| }, | |||
| showDatabaseModal: { | |||
There was a problem hiding this comment.
one of the setup guide step is to redirect to database list view and pop open the database modal
suddjian
reviewed
Jul 1, 2022
superset-frontend/packages/superset-ui-core/src/style/index.tsx
Outdated
Show resolved
Hide resolved
suddjian
reviewed
Jul 1, 2022
superset-frontend/packages/superset-ui-core/src/ui-overrides/UiOverrideRegistry.ts
Outdated
Show resolved
Hide resolved
|
I removed the image asset since I believe that's meant to be part of the Preset feature, not part of Superset |
added 2 commits
July 1, 2022 11:31
akshatsri
pushed a commit
to charan1314/superset
that referenced
this pull request
Jul 19, 2022
* welcome top extension * show database modal * add test * Delete lines.svg * rename to banner * remove lines Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION