Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: welcome page user authentication check #20605

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 5, 2022

SUMMARY

Small "fix" for the public welcome page, by first asserting if g.user exists enables possible exceptions to be raised and handled accordingly on custom security managers (eg: JWT token exceptions).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #20605 (181cba5) into master (309327d) will decrease coverage by 11.80%.
The diff coverage is 100.00%.

❗ Current head 181cba5 differs from pull request most recent head aab49aa. Consider uploading reports for the commit aab49aa to get more accurate results

@@             Coverage Diff             @@
##           master   #20605       +/-   ##
===========================================
- Coverage   66.79%   54.98%   -11.81%     
===========================================
  Files        1754     1754               
  Lines       65565    65565               
  Branches     6935     6935               
===========================================
- Hits        43793    36051     -7742     
- Misses      20017    27759     +7742     
  Partials     1755     1755               
Flag Coverage Δ
hive 53.77% <100.00%> (ø)
mysql ?
postgres ?
presto 53.63% <100.00%> (ø)
python 58.37% <100.00%> (-24.49%) ⬇️
sqlite ?
unit 50.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-ui-chart-controls/src/operators/pivotOperator.ts 100.00% <ø> (ø)
...controls/src/operators/timeComparePivotOperator.ts 100.00% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 50.00% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 51.66% <100.00%> (ø)
superset/views/core.py 34.79% <100.00%> (-42.67%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/upsert.py 0.00% <0.00%> (-89.59%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-89.37%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
... and 281 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309327d...aab49aa. Read the comment docs.

@dpgaspar dpgaspar merged commit 92bf1b8 into apache:master Jul 5, 2022
@dpgaspar dpgaspar deleted the fix/welcome_page_auth branch July 5, 2022 16:04
@michael-s-molina michael-s-molina added v2.0 and removed v2.0 labels Jul 6, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants