Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration head #20635

Closed
wants to merge 1 commit into from
Closed

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jul 7, 2022

SUMMARY

fix double head migration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

Before

image

TESTING INSTRUCTIONS

make sure add user id_dttm_idx_to_log_model is the latest commit

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #20635 (25c1f13) into master (d16f274) will increase coverage by 15.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #20635       +/-   ##
===========================================
+ Coverage   51.28%   66.82%   +15.53%     
===========================================
  Files        1752     1752               
  Lines       65651    65651               
  Branches     6944     6944               
===========================================
+ Hits        33668    43868    +10200     
+ Misses      30220    20020    -10200     
  Partials     1763     1763               
Flag Coverage Δ
hive 53.82% <ø> (?)
mysql 82.39% <ø> (?)
postgres 82.46% <ø> (?)
presto 53.68% <ø> (?)
python 82.89% <ø> (+32.20%) ⬆️
sqlite 82.25% <ø> (?)
unit 50.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.47% <0.00%> (+0.32%) ⬆️
superset/views/database/views.py 31.36% <0.00%> (+0.90%) ⬆️
superset/initialization/__init__.py 91.66% <0.00%> (+1.04%) ⬆️
superset/tables/models.py 67.53% <0.00%> (+1.29%) ⬆️
superset/charts/schemas.py 99.35% <0.00%> (+1.94%) ⬆️
superset/explore/utils.py 100.00% <0.00%> (+2.12%) ⬆️
superset/extensions/__init__.py 98.82% <0.00%> (+2.35%) ⬆️
superset/databases/commands/exceptions.py 96.92% <0.00%> (+3.07%) ⬆️
superset/queries/schemas.py 100.00% <0.00%> (+3.33%) ⬆️
superset/sql_parse.py 97.07% <0.00%> (+3.50%) ⬆️
... and 305 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16f274...25c1f13. Read the comment docs.

@zhaoyongjie
Copy link
Member Author

fix it in #20359

@zhaoyongjie zhaoyongjie closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants