Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(databases): Display for credentials input #20637

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

  • Since our DatabaseConnectionForm is wrapped in a AntD Form now, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
error

AFTER:
test

TESTING INSTRUCTIONS

  1. Visit the "Databases" page, hit the "+database+ button
  2. Select "Google Bigquery" db
  3. Upload JSON file
  4. Expected Result: The input field (UPLOAD CREDENTIALS) is hidden and only the button is visible.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@yousoph
Copy link
Member

yousoph commented Jul 7, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

@yousoph Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

@yousoph Ephemeral environment creation failed. Please check the Actions logs for details.

- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #20637 (c91c564) into master (c91c564) will not change coverage.
The diff coverage is n/a.

❗ Current head c91c564 differs from pull request most recent head b8a6e34. Consider uploading reports for the commit b8a6e34 to get more accurate results

@@           Coverage Diff           @@
##           master   #20637   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files        1753     1753           
  Lines       65618    65618           
  Branches     6952     6952           
=======================================
  Hits        43831    43831           
  Misses      20023    20023           
  Partials     1764     1764           
Flag Coverage Δ
hive 53.88% <0.00%> (ø)
javascript 51.86% <0.00%> (ø)
mysql 82.36% <0.00%> (ø)
postgres 82.43% <0.00%> (ø)
presto 53.74% <0.00%> (ø)
python 82.87% <0.00%> (ø)
sqlite 82.22% <0.00%> (ø)
unit 50.79% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91c564...b8a6e34. Read the comment docs.

@apache apache deleted a comment from github-actions bot Jul 7, 2022
@apache apache deleted a comment from github-actions bot Jul 7, 2022
@rusackas
Copy link
Member

rusackas commented Jul 7, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

@rusackas Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

@rusackas Ephemeral environment creation failed. Please check the Actions logs for details.

@rusackas rusackas merged commit e331640 into apache:master Jul 7, 2022
@Antonio-RiveroMartnez Antonio-RiveroMartnez deleted the FIX-52053 branch July 8, 2022 12:19
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Jul 8, 2022
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.

(cherry picked from commit e331640)
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Jul 12, 2022
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.

(cherry picked from commit e331640)
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Jul 12, 2022
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.

(cherry picked from commit e331640)
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.27 size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants