Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treemap-v2): color scheme not work when there is only one dimension #20671

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

The scenario for this PR fix is that changing color scheme in treemap v2 does not see any change if there is only one dimension.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Tree.Layout.mp4

after

2022-07-11.11.33.08.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #20671 (4e0972d) into master (c29261b) will not change coverage.
The diff coverage is n/a.

❗ Current head 4e0972d differs from pull request most recent head 36c5252. Consider uploading reports for the commit 36c5252 to get more accurate results

@@           Coverage Diff           @@
##           master   #20671   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1753     1753           
  Lines       65823    65823           
  Branches     7007     7007           
=======================================
  Hits        44005    44005           
  Misses      20032    20032           
  Partials     1786     1786           
Flag Coverage Δ
javascript 51.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin-chart-echarts/src/Treemap/transformProps.ts 51.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29261b...36c5252. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review July 13, 2022 08:06
@zhaoyongjie zhaoyongjie merged commit bd6037e into apache:master Jul 13, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants