Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Native filter on the dashboard with multiple tabs is displayed as out of scope #20693

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix(dashboard): Native filter on the dashboard with multiple tabs is displayed as out of scope #20693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset-frontend/src/dashboard/containers/DashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug }: PageProps) => {
const isOldRison = getUrlParam(URL_PARAMS.nativeFilters);

let dataMask = nativeFilterKeyValue || {};
let activeTabs: string[] | undefined = [];
// activeTabs is initialized with undefined so that it doesn't override
// the currently stored value when hydrating
let activeTabs: string[] | undefined;
if (permalinkKey) {
const permalinkValue = await getPermalinkValue(permalinkKey);
if (permalinkValue) {
Expand Down